Skip to content

Fix typo #9435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typo #9435

wants to merge 1 commit into from

Conversation

liviubalan
Copy link
Contributor

No description provided.

@liviubalan
Copy link
Contributor Author

On 3.4 branch the paragraph differs a little. Please tell me if I need to make a different pull request on 3.4 branch

@wouterj wouterj closed this Mar 14, 2018
wouterj added a commit that referenced this pull request Mar 14, 2018
@wouterj
minor #9435 Fix typo (liviubalan)
16a5ac9 
This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #9435).

Discussion
----------

Fix typo

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

868e3c4 Fix typo
@wouterj
Copy link
Member

wouterj commented Mar 14, 2018

Thanks again! This one is merged in 2.7 as well. I've merged your two changes up to master. In 3.4, I think this typo no longer exists, so it's not included in 581d779 . Please comment if I'm wrong :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liviubalan @wouterj @carsonbot